[webkit-reviews] review granted: [Bug 15914] [GTK] Implement Unicode functionality using GLib : [Attachment 23124] patch updated for probing for iconv encodings, updated to revision 36025

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 2 13:04:12 PDT 2008


Dominik Röttsches <dominik.roettsches at access-company.com> has granted 's
request for review:
Bug 15914: [GTK] Implement Unicode functionality using GLib
https://bugs.webkit.org/show_bug.cgi?id=15914

Attachment 23124: patch updated for probing for iconv encodings, updated to
revision 36025
https://bugs.webkit.org/attachment.cgi?id=23124&action=edit

------- Additional Comments from Dominik Röttsches
<dominik.roettsches at access-company.com>
I updated Jürg's patch for probing the list of codecs that are supported by
iconv (as stated on the libiconv web page). TIS-620, WINDOWS-1251, EUC-KR,
WINDOWS-1253 added manually. This patch now works without a dependency to
libiconv, but relies on hard-coded codec tables. It could serve as an interim
solution until it's decided to change the text codecs architecture.


More information about the webkit-reviews mailing list