[webkit-reviews] review denied: [Bug 20495] paintBorder in RenderObject paint two times the corners : [Attachment 23099] fix paintBorder in RenderObject and remove the bug on acid2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mario Bensi <mbensi at pleyo.com>'s
request for review:
Bug 20495: paintBorder in RenderObject paint two times the corners
https://bugs.webkit.org/show_bug.cgi?id=20495

Attachment 23099: fix paintBorder in RenderObject and remove the bug on acid2
https://bugs.webkit.org/attachment.cgi?id=23099&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I can't evaluate the correctness of this patch, but I can say that the
copy-paste code used here is a bad idea.

The if should be used to store the necessary variables, and then a single
drawBorder call should be used.

It appears that you're changing where it's drawing from/to.  It seems the code
right above this adjusts y and y2 in an if, why can't this change also do the
same? (use an if to adjust y and y2?  or copy y and y2 into some other nicely
named variables and ajust them there).	Copy/paste of code which is confusing
to begin with is a bad idea.  Ideally this method would be cleaned up to use
FloatPoint and possibly to take fewer parameters :)