[webkit-reviews] review requested: [Bug 19408] Constant folding in parser : [Attachment 23095] Fold *, /, +, <<, >>, ~ operators (v5)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 1 03:26:20 PDT 2008
Gabor Loki <loki at inf.u-szeged.hu> has asked for review:
Bug 19408: Constant folding in parser
https://bugs.webkit.org/show_bug.cgi?id=19408
Attachment 23095: Fold *, /, +, <<, >>, ~ operators (v5)
https://bugs.webkit.org/attachment.cgi?id=23095&action=edit
------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
I have added the requested changes:
- rename m1, m2 to expr1, expr2
- rename locHasAssignments to rightHasAssignments
- remove shouldBeRound function and use double-precision values in the test
cases
More information about the webkit-reviews
mailing list