[webkit-reviews] review requested: [Bug 15715] Nested XSL stylesheets can produce memory corruption : [Attachment 24827] Patch addressing Darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 31 17:31:57 PDT 2008

Pam Greene <pam at chromium.org> has asked  for review:
Bug 15715: Nested XSL stylesheets can produce memory corruption

Attachment 24827: Patch addressing Darin's comments

------- Additional Comments from Pam Greene <pam at chromium.org>
Jonathan was working on Chromium but has since been called to work on some
other things.  I'm taking over getting his patch finished up.

> Mark Rowe requested a regression test; I'd like to see the patch include one.


> Since parentStyleSheet() is never used outside the XSLStyleSheet class, I
> think we need to define a function.


> What guarantees that m_parentStyleSheet is not left pointing to a deleted
> object?

Sorry, I don't know this code that well; I'm just working with the patch and
tests.	If it's a concern, I'll ask Jonathan to weigh in.

> +    void setParentStyleSheet(XSLStyleSheet* parent) {
> +	  m_parentStyleSheet = parent; 
> +	  if (parent)
> +	     setOwnerDocument(parent->ownerDocument());
> +    }
> The opening brace is supposed to go on a separate line. This function is also

> getting long enough that it might be better to not put it inline.

Style fixed and method out-lined.

> Are there any callers left for XSLStyleSheet::setOwnerDocument()? If not,
> perhaps we should remove it.


More information about the webkit-reviews mailing list