[webkit-reviews] review granted: [Bug 22008] Add windows support for selecting multiple files in a file upload control : [Attachment 24818] updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adele Peterson <adele at apple.com>'s
request for review:
Bug 22008: Add windows support for selecting multiple files in a file upload
control
https://bugs.webkit.org/show_bug.cgi?id=22008

Attachment 24818: updated patch
https://bugs.webkit.org/attachment.cgi?id=24818&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (_tcscat_s(buffer, ARRAYSIZE(buffer), TEXT("\\shell32.dll")))

As we discussed in person, you can leave out the ARRAYSIZE here and it will get
the size automatically, and you should. Same in the other _tcscat_s call site.

> +// When you call GetOpenFileName, if the size of the buffer is too small,
> +// MSDN says that the first two bytes of the buffer contain the required
size for the file selection, in bytes or characters
> +// So we can assume the required size can't be more than the maximum value
for a short.
> +static const unsigned short maxFilePathsListSize = USHRT_MAX;

This should be size_t.

r=me