[webkit-reviews] review denied: [Bug 21956] DragController needs to be made aware of async drags : [Attachment 24781] [1/1] only call dragEnded() on PLATFORM(MAC)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 30 15:12:28 PDT 2008


Oliver Hunt <oliver at apple.com> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 21956: DragController needs to be made aware of async drags
https://bugs.webkit.org/show_bug.cgi?id=21956

Attachment 24781: [1/1] only call dragEnded() on PLATFORM(MAC)
https://bugs.webkit.org/attachment.cgi?id=24781&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I was talking to Sam about this, and he suggested that instead of putting an
icky ifdef here, we add a new method to DragController, say
DragController::cleanupAfterDrag or something (I'm really no good with function
names), which on mac would just call dragEnded and on everything else would be
a no-op


More information about the webkit-reviews mailing list