[webkit-reviews] review denied: [Bug 21956] DragController needs to be made aware of async drags : [Attachment 24754] Make DragController async-drag aware

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 29 14:11:19 PDT 2008


Oliver Hunt <oliver at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 21956: DragController needs to be made aware of async drags
https://bugs.webkit.org/show_bug.cgi?id=21956

Attachment 24754: Make DragController async-drag aware
https://bugs.webkit.org/attachment.cgi?id=24754&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You can't just not call dragEnded, it will fail to reset appropriate logic.

More over this ifdef is awful, and chromium is the only platform for which it
is "necessary" -- i have never encountered any platform on which drag and drop
is not a synchronous action, and would actually consider this a bug in
chromium.


More information about the webkit-reviews mailing list