[webkit-reviews] review granted: [Bug 21930] Add MediaPlayerPrivateChromium to MediaPlayer : [Attachment 24750] Includes ChangeLog entry and I fixed the order (we no longer define WIN/MAC/etc. so it doesn't have to be first)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 21930: Add MediaPlayerPrivateChromium to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=21930

Attachment 24750: Includes ChangeLog entry and I fixed the order (we no longer
define WIN/MAC/etc. so it doesn't have to be first)
https://bugs.webkit.org/attachment.cgi?id=24750&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 37973)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,12 @@
> +2008-10-29  Andrew Scherkus	<scherkus at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add MediaPlayerPrivate header include for Chromium platform.
> +
> +	   * WebCore\platform\graphics\MediaPlayer.cpp
> +:
> +

I'm not sure how you're generating ChangeLog files but there are three problems
with this one:

    1) The path uses \ rather than / -- we use / in our ChangeLog even though
Windows is one of the platforms we support.
    2) The colon is on a separate line after the filename.
    3) Doesn't contain a link to this bug on bugs.webkit.org; we prefer to do
that.

The person who lands this patch will need to fix these problems.

r=me