[webkit-reviews] review cancelled: [Bug 21611] Unnecessary operations, duplicated codes in the CodeGenerator : [Attachment 24360] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 29 09:45:45 PDT 2008

Judit Jász <jasy at inf.u-szeged.hu> has cancelled Judit Jász
<jasy at inf.u-szeged.hu>'s request for review:
Bug 21611: Unnecessary operations, duplicated codes in the CodeGenerator

Attachment 24360: proposed patch

------- Additional Comments from Judit Jász <jasy at inf.u-szeged.hu>
I have modified my earlier patch. 
My aim with the refactoring of the CodeGenerator is to see how the implemented
peepholes work now. Because they use the same steps almost everywhere, the code
could be more understandable if we can reduce the number of duplicated code

An other aim of this work is to eliminating the unnecessary steps of these
peepholes. In these peepholes we change only the opcode of the last
instructions and some of the operands. It is unnecessary to delete the last
instruction and build a new one, it is suffucuent if we change the
corresponding part of the last instruction.

More information about the webkit-reviews mailing list