[webkit-reviews] review granted: [Bug 21932] Add non-pointer symbol lookups to SoftLinking.h : [Attachment 24728] looks up non pointer symbols

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 28 13:54:28 PDT 2008


Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 21932: Add non-pointer symbol lookups to SoftLinking.h
https://bugs.webkit.org/show_bug.cgi?id=21932

Attachment 24728: looks up non pointer symbols
https://bugs.webkit.org/attachment.cgi?id=24728&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The change seems fine. But I'm not sure "SYMBOL" is a good name for this.
They're all symbols. Maybe "OBJECT"?

r=me as-is, but please consider other names


More information about the webkit-reviews mailing list