[webkit-reviews] review granted: [Bug 21921] MessagePort messages are dispatched to documents that are not fully active : [Attachment 24711] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 28 11:35:27 PDT 2008


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 21921: MessagePort messages are dispatched to documents that are not fully
active
https://bugs.webkit.org/show_bug.cgi?id=21921

Attachment 24711: proposed fix
https://bugs.webkit.org/attachment.cgi?id=24711&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm a little worried that this kind of check might be needed in more cases
other than just this event listener function. Is there a way to make this
change a more natural part of how you get the frame from the window in the
first place? What's a good way to audit the rest of the code to se if we need
other changes like this? Is there a way to change the design to fill this
"crack in the foundation"?

r=me


More information about the webkit-reviews mailing list