[webkit-reviews] review requested: [Bug 21918] A JavaScript Exception abstraction : [Attachment 24718] Removed ExceptionCatcher, added inlines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 28 09:16:36 PDT 2008


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 21918: A JavaScript Exception abstraction
https://bugs.webkit.org/show_bug.cgi?id=21918

Attachment 24718: Removed ExceptionCatcher, added inlines
https://bugs.webkit.org/attachment.cgi?id=24718&action=edit

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
You know, I woke up this morning and had exact same thought about
ExceptionCatcher. Here's an updated patch, with it removed. I also added
"inline" to all ExceptionContext methods, and hope that the compiler will agree
with me that they are simple enough to be treated as such.

Let me know whatcha think.


More information about the webkit-reviews mailing list