[webkit-reviews] review denied: [Bug 21475] Provide support for the Geolocation API : [Attachment 24627] updated patch (so ddkilzer can apply it for me)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 24 00:45:07 PDT 2008
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 21475: Provide support for the Geolocation API
https://bugs.webkit.org/show_bug.cgi?id=21475
Attachment 24627: updated patch (so ddkilzer can apply it for me)
https://bugs.webkit.org/attachment.cgi?id=24627&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
I rolled out r37840 and r37841. There are too many issues yet to be resolved
with this patch.
Committed r37842
http://trac.webkit.org/changeset/37842
- Derived sources missing from Xcode project. (Adding them causes build
failures.)
DerivedSources/WebCore/JSPositionCallback.cpp
DerivedSources/WebCore/JSPositionCallback.h
DerivedSources/WebCore/JSPositionErrorCallback.cpp
DerivedSources/WebCore/JSPositionErrorCallback.h
All DOM* generated classes for *.idl files.
- Changes to WebKit/mac/MigrateHeaders.make for DOM* classes.
- Windows build breaks.
- GTK, Qt and wx builds break (Qt is currently broken) and each platform's
build files are missing *.idl and other source files.
More information about the webkit-reviews
mailing list