[webkit-reviews] review requested: [Bug 18703] changing the 'size' property on a text input does not affect its length : [Attachment 24621] Possible patch to bug 18703.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 15:07:57 PDT 2008


Glenn Wilson <gwilson at google.com> has asked  for review:
Bug 18703: changing the 'size' property on a text input does not affect its
length
https://bugs.webkit.org/show_bug.cgi?id=18703

Attachment 24621: Possible patch to bug 18703.
https://bugs.webkit.org/attachment.cgi?id=24621&action=edit

------- Additional Comments from Glenn Wilson <gwilson at google.com>
Ok, here's the modified patch with the suggested changes....it is probably much
simpler this way, so thanks for the feedback :)

I added the call that you specified, but I also had to add a check whether the
renderer was valid first.  I debated checking the type of the input element
too, but decided against it since non-text form input elements could also have
sizes that could be changed (the password type comes to mind.)	

I originally spotted 'idAttr' in Element, and thought size was also a valid DOM
attribute that could be tested, but I didn't realize it is HTML-specific. 
Sorry about that.

Thanks for the review!


More information about the webkit-reviews mailing list