[webkit-reviews] review granted: [Bug 21839] SVGAnimatedTemplate needs HashMap.h included explicitly : [Attachment 24616] SVGAnimatedTemplate.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 14:09:29 PDT 2008

Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 21839: SVGAnimatedTemplate needs HashMap.h included explicitly

Attachment 24616: SVGAnimatedTemplate.h

------- Additional Comments from Darin Adler <darin at apple.com>
Change Log needs to have your name, not just dglazkov, in the header.

Also, you should remove the "WARNING: NO TEST CASES ADDED OR CHANGED" if you
don't need any tests and add a link to the bug.

It saves the committer time if you do those things right.

The reason this isn't needed for JSC platforms is that PlatformString.h
includes <kjs/identifier.h> which ends up including HashMap.h. To avoid making
ourselves crazy, we might just want to add a HashMap.h include to
PlatformString.h to eliminate this difference.

r=me, as is

More information about the webkit-reviews mailing list