[webkit-reviews] review granted: [Bug 21817] Manual profiler tests should be made into layout tests : [Attachment 24606] Actual changes to the tests

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 21817: Manual profiler tests should be made into layout tests
https://bugs.webkit.org/show_bug.cgi?id=21817

Attachment 24606: Actual changes to the tests
https://bugs.webkit.org/attachment.cgi?id=24606&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
+	 - Here are the changes to the tests.  The most significant part is the

+	 change to profiler-test-JS-resources.js

Not a good ChangeLog entry. Describe the changes/additions.

+    ++tab;

A better name for tab would be indentLevel.

+    for (var j = 0; j < children.length; ++j)

No need to use j here, you can use i again.

r=me, but you should consider some of these changes.