[webkit-reviews] review denied: [Bug 21808] Update CG ifdefs to include PLATFORM(CHROMIUM) : [Attachment 24567] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 23 12:42:27 PDT 2008
Eric Seidel <eric at webkit.org> has denied Mike Pinkerton
<pinkerton at chromium.org>'s request for review:
Bug 21808: Update CG ifdefs to include PLATFORM(CHROMIUM)
https://bugs.webkit.org/show_bug.cgi?id=21808
Attachment 24567: patch
https://bugs.webkit.org/attachment.cgi?id=24567&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Your email address is missing.
set EMAIL_ADDRESS environment variable
I think this should use PLATFORM(DARWIN) instead since this is a platform
thing, not a "apple's mac port" thing. If someone is including this header
they're already wishing to use CG, so the question is just if we're using CG on
a mac or a windows machine. I'll land a fixed version for you.
More information about the webkit-reviews
mailing list