[webkit-reviews] review denied: [Bug 20430] DOMWindow is missing lots of SVG* constructor objects : [Attachment 24572] Expose many missing constructors on window

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Eric Seidel <eric at webkit.org>'s request
for review:
Bug 20430: DOMWindow is missing lots of SVG* constructor objects
https://bugs.webkit.org/show_bug.cgi?id=20430

Attachment 24572: Expose many missing constructors on window
https://bugs.webkit.org/attachment.cgi?id=24572&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +	   * svg/custom/global-constructors-expected.txt: Added.
> +	   * svg/custom/global-constructors.html: Added.
You need to add the .js part of the test.


I think you should put this in its own patch as it is unrelated and needs its
own test.
> +++ b/WebCore/svg/SVGAnimateMotionElement.idl
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (C) 2006 Apple Computer, Inc.
This should have your copyright.


> +module svg {
> +
> +    interface [Conditional=SVG_ANIMATION] SVGAnimateMotionElement :
SVGAnimationElement {
This needs GenerateConstructor.
 
> -    interface [Conditional=SVG, GenerateConstructor, ObjCProtocol]
SVGZoomAndPan {
> +    interface [
> +	   Conditional=SVG,
> +	   GenerateConstructor,
> +	   ObjCProtocol
> +    ] SVGZoomAndPan {
I don't think this should have a constructor, at least until we decide what to
do with pure interfaces.

Many additional classes need the GenerateConstructor extended attribute.  To
make your life easier, you may want to reverse it, and make it necessary to opt
out or a constructor.

r-