[webkit-reviews] review granted: [Bug 21817] Manual profiler tests should be made into layout tests : [Attachment 24601] The moving and renaming of the manual files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 11:20:17 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has granted Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 21817: Manual profiler tests should be made into layout tests
https://bugs.webkit.org/show_bug.cgi?id=21817

Attachment 24601: The moving and renaming of the manual files
https://bugs.webkit.org/attachment.cgi?id=24601&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
How do you plan to make the expected results meaningful? I think a better first
step would be to create a shared function that outputs the profile data in a
text representation that shows the tree structure. As-is just moving these
tests to the LayoutTests directory does nothing useful.


More information about the webkit-reviews mailing list