[webkit-reviews] review granted: [Bug 21831] Fix create_hash_table for Perl 5.10 : [Attachment 24603] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 21831: Fix create_hash_table for Perl 5.10
https://bugs.webkit.org/show_bug.cgi?id=21831

Attachment 24603: Patch v1
https://bugs.webkit.org/attachment.cgi?id=24603&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
> commit 9ad34c84b18ab388ac50ad70fe7aac879ad74f6d
> Author: David Kilzer <ddkilzer at apple.com>
> Date:   Thu Oct 23 11:16:14 2008 -0700
> 
>	      Bug 21831: Fix create_hash_table for Perl 5.10
>     
>	      <https://bugs.webkit.org/show_bug.cgi?id=21831>
>     
>	      Reviewed by NOBODY (OOPS!).
>     
>	      * kjs/create_hash_table: Escaped square brackets so that Perl
5.10
>	      doesn't try to use @nameEntries.
> 
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index 3fbfd0c..50742fd 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,14 @@
> +2008-10-23  David Kilzer  <ddkilzer at apple.com>
> +
> +	   Bug 21831: Fix create_hash_table for Perl 5.10
> +
> +	   <https://bugs.webkit.org/show_bug.cgi?id=21831>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
> +	   doesn't try to use @nameEntries.
> +
>  2008-10-22  Darin Adler  <darin at apple.com>
>  
>	   Reviewed by Sam Weinig.
> diff --git a/JavaScriptCore/kjs/create_hash_table
b/JavaScriptCore/kjs/create_hash_table
> index d98cc30..829a024 100755
> --- a/JavaScriptCore/kjs/create_hash_table
> +++ b/JavaScriptCore/kjs/create_hash_table
> @@ -215,7 +215,7 @@ sub output() {
>	   print "\nnamespace JSC {\n";
>      }
>      my $count = scalar @keys + 1;
> -    print "\nstatic const struct HashTableValue ${nameEntries}[$count] =
{\n";
> +    print "\nstatic const struct HashTableValue ${nameEntries}\[$count\] =
{\n";
>      my $i = 0;
>      foreach my $key (@keys) {
>	   my $firstValue = "";