[webkit-reviews] review granted: [Bug 21826] Add accessor for SecurityOrigin::m_domainWasSetInDOM : [Attachment 24594] le patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 23 06:46:50 PDT 2008

Sam Weinig <sam at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 21826: Add accessor for SecurityOrigin::m_domainWasSetInDOM

Attachment 24594: le patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
+ * Copyright (C) 2007-2008 Apple Inc. All rights reserved.
We like to use comma delineated years.

	 void setDomainFromDOM(const String& newDomain);
+	 bool domainWasSetInDOM() const { return m_domainWasSetInDOM; }
These should be paragraphed together.

I am a little unclear about why this is necessary, the SecurityOrigin it self
should be sufficient for a fast compare.  Perhaps we can remove this later.

More information about the webkit-reviews mailing list