[webkit-reviews] review denied: [Bug 19225] JSProfiler: Create automated profiler tests : [Attachment 24574] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 22 15:29:34 PDT 2008
Oliver Hunt <oliver at apple.com> has denied Kevin McCullough
<kmccullough at apple.com>'s request for review:
Bug 19225: JSProfiler: Create automated profiler tests
https://bugs.webkit.org/show_bug.cgi?id=19225
Attachment 24574: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24574&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
I don't like
46 if(iter == end)
47 return constructArray(exec, list);
48
49 do {
50 list.append(toJS(exec, iter->get()));
51 ++iter;
52 } while (iter != end);
i think
ArgList list;
ProfilesArray::const_iterator end = profiles.end();
for (ProfilesArray::const_iterator iter = profiles.begin(); iter != end;
++iter)
list.append(toJS(exec, iter->get()));
return constructArray(exec, list);
is better as it's simpler, smaller, and more in keeping with the style of
similar code elsewhere.
More information about the webkit-reviews
mailing list