[webkit-reviews] review granted: [Bug 21803] Fuse op_jfalse with op_eq_null and op_neq_null : [Attachment 24568] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 22 13:55:13 PDT 2008


Geoffrey Garen <ggaren at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 21803: Fuse op_jfalse with op_eq_null and op_neq_null
https://bugs.webkit.org/show_bug.cgi?id=21803

Attachment 24568: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24568&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
 3054	      /* jneq_null cond(r) target(offset)
 3036	      /* jeq_null cond(r) target(offset)

Let's call "cond" "src", like you suggested.

Seems like we might get a little speedup out of experimenting with the asm a
little, but this looks good.

r=me


More information about the webkit-reviews mailing list