[webkit-reviews] review denied: [Bug 21757] Should not define PLATFORM(WIN, MAC, GTK) when PLATFORM(CHROMIUM) is defined : [Attachment 24528] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 21 14:45:49 PDT 2008


Eric Seidel <eric at webkit.org> has denied Darin Fisher (Google)
<darin at chromium.org>'s request for review:
Bug 21757: Should not define PLATFORM(WIN,MAC,GTK) when PLATFORM(CHROMIUM) is
defined
https://bugs.webkit.org/show_bug.cgi?id=21757

Attachment 24528: v1 patch
https://bugs.webkit.org/attachment.cgi?id=24528&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
The platform.h changes look wrong.  I see an added #if w/o any #endif


More information about the webkit-reviews mailing list