[webkit-reviews] review requested: [Bug 21736] Long-dead decoded image data make up for most of the object cache's memory use over time : [Attachment 24495] Destroy decoded image data that has been dead for one minute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 18 17:30:59 PDT 2008


mitz at webkit.org has asked  for review:
Bug 21736: Long-dead decoded image data make up for most of the object cache's
memory use over time
https://bugs.webkit.org/show_bug.cgi?id=21736

Attachment 24495: Destroy decoded image data that has been dead for one minute
https://bugs.webkit.org/attachment.cgi?id=24495&action=edit

------- Additional Comments from mitz at webkit.org
This is the most straightforward patch, I think. The cost of an extra timer in
each CachedImage appears to be negligible, and managing a queue with a single
timer in the Cache turned out to be more complicated and had no significant
benefit. Likewise, adding an intermediate subclass
("CachedObjectWithDecodedDataThatDestroysItselfOnATimer") between CachedObject
and CachedImage seemed unnecessary for as long as images are the only objects
with decoded data.


More information about the webkit-reviews mailing list