[webkit-reviews] review requested: [Bug 21407] Add a number of new layout tests, all passing on ToT : [Attachment 24460] Better XML declaration tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 17 13:59:52 PDT 2008


Pam Greene <pam at chromium.org> has asked  for review:
Bug 21407: Add a number of new layout tests, all passing on ToT
https://bugs.webkit.org/show_bug.cgi?id=21407

Attachment 24460: Better XML declaration tests
https://bugs.webkit.org/attachment.cgi?id=24460&action=edit

------- Additional Comments from Pam Greene <pam at chromium.org>
Fair enough.  I spoke to eroman, who reported bug 17814 and wrote the
bad-xml-entity test, and he thought it would have shown up in a .xml file too. 
But more coverage never hurts, so I've renamed the test to
xml-declaration-missing-ending-mark.*, included both .html and .xml versions,
and improved/expanded the text within the tests to both use the right
terminology and explain why there are two.

No other changes from the previous patch.


More information about the webkit-reviews mailing list