[webkit-reviews] review granted: [Bug 21708] REGRESSION(r37622): starting a debugging session in another Web Inspector does show any scripts : [Attachment 24458] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 17 09:37:18 PDT 2008


Darin Adler <darin at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 21708: REGRESSION(r37622): starting a debugging session in another Web
Inspector does show any scripts
https://bugs.webkit.org/show_bug.cgi?id=21708

Attachment 24458: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24458&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 void didAddListener(Page* page = 0);
+	 void didRemoveListener(Page* page = 0);

Don't need the name "page" here for the argument. Seems unclear what the "0"
value means. I guess it means "global listener", but that should be mentioned
explicitly.

r=me


More information about the webkit-reviews mailing list