[webkit-reviews] review denied: [Bug 21495] DRT tool needs to capture real "on screen" window content : [Attachment 24279] 3rd revision

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 17 04:27:43 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Pierre-Olivier Latour
<pol at apple.com>'s request for review:
Bug 21495: DRT tool needs to capture real "on screen" window content
https://bugs.webkit.org/show_bug.cgi?id=21495

Attachment 24279: 3rd revision
https://bugs.webkit.org/attachment.cgi?id=24279&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This should just use the BUILDING_ON_TIGER macro defined in
DumpRenderTreeMac.h.

#ifndef BUILDING_ON_TIGER
// new code
#else
// old code
#endif

Otherwise looks good.


More information about the webkit-reviews mailing list