[webkit-reviews] review granted: [Bug 21633] Avoid using a HashMap when there is only a single transition : [Attachment 24382] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 15 20:46:42 PDT 2008


Maciej Stachowiak <mjs at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 21633: Avoid using a HashMap when there is only a single transition
https://bugs.webkit.org/show_bug.cgi?id=21633

Attachment 24382: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24382&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

But it would be nice if we could abstract away the single-transition
optimization a bit, by having some helper functions that hide the core logic
(e.g. one to get an existing transition for a property - it could check either
the single entry or the hashtable as appropriate) etc.


More information about the webkit-reviews mailing list