[webkit-reviews] review granted: [Bug 21211] [CURL] Upload doesn't work because cancel is called : [Attachment 23907] Don't call cancel if the upload was successful

[bugzilla-daemon at webkit.org]

Holger Freyther <freyther at handhelds.org> has granted Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 21211: [CURL] Upload doesn't work because cancel is called
https://bugs.webkit.org/show_bug.cgi?id=21211

Attachment 23907: Don't call cancel if the upload was successful
https://bugs.webkit.org/attachment.cgi?id=23907&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Sounds reasonable. The only complain would be to always put the Vector on the
stack. In the majority of code we have early exits. e.g
  if (!httpBody())
    return false;

  return m_formDataElementIndex <
m_resourceHandle()->request().httpBody()->elements().size();

but this is no hard requirement but something to keep in mind.