[webkit-reviews] review requested: [Bug 21475] Provide support for the Geolocation API : [Attachment 24365] Address navigator properties enumeration, add test for when Geolocation is not implmented

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 15 13:11:45 PDT 2008


Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 21475: Provide support for the Geolocation API
https://bugs.webkit.org/show_bug.cgi?id=21475

Attachment 24365: Address navigator properties enumeration, add test for when
Geolocation is not implmented
https://bugs.webkit.org/attachment.cgi?id=24365&action=edit

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
Geolocation support will compile. Navigator.idl and Navigator.cpp now use
ENABLE(GEOLOCATION) to turn this off. All the support code compiles but is not
linked in. I added a test for when ENABLE(GEOLOCATION) is off. If it is
implemented, this test will fail, and should be ignored. Once it is implemented
a new test will need to be created.

Due to how Navigator's properties are created (via IDL) with
ENABLE_GEOLOCATION, it isn't clear how to have a test that will determine at
runtime if Geolocation support is available. So I did not do any DRT time only
work.


More information about the webkit-reviews mailing list