[webkit-reviews] review granted: [Bug 21610] run-webkit-threads --threaded crashes in StructureID destructor : [Attachment 24359] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 15 09:11:40 PDT 2008


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 21610: run-webkit-threads --threaded crashes in StructureID destructor
https://bugs.webkit.org/show_bug.cgi?id=21610

Attachment 24359: proposed fix
https://bugs.webkit.org/attachment.cgi?id=24359&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
 #include <wtf/RefPtr.h>
+#if ENABLE(JSC_MULTIPLE_THREADS)
+#include <wtf/Threading.h>
+#endif

#ifdef'd includes normally go in a separate paragraph.

Since this is debug-only code it would be nice if there was some no-op version
of Mutex and MutexLocker for the single-thread case to keep the #if to a
minimum -- performance is not a critical concern.

r=me


More information about the webkit-reviews mailing list