[webkit-reviews] review requested: [Bug 21611] Unnecessary operations, duplicated codes in the CodeGenerator : [Attachment 24360] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 15 07:30:02 PDT 2008


Judit Jász <jasy at inf.u-szeged.hu> has asked  for review:
Bug 21611: Unnecessary operations, duplicated codes in the CodeGenerator
https://bugs.webkit.org/show_bug.cgi?id=21611

Attachment 24360: proposed patch
https://bugs.webkit.org/attachment.cgi?id=24360&action=edit

------- Additional Comments from Judit Jász <jasy at inf.u-szeged.hu>
The patch has a measurable but not significant impact on the performance. 
Two new methods are introduced, which modify the value of the last instruction.
In this way we do not have to remove the last instruction and after add a new
one to the instruction chain if we only want to modify the last instruction.
The patch contains other smaller code refactorings, which eliminates some
duplicated codes.


More information about the webkit-reviews mailing list