[webkit-reviews] review requested: [Bug 21596] WebCore::Cache should use parsed Pragma and Cache-Control headers : [Attachment 24352] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 14 17:27:41 PDT 2008


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers
https://bugs.webkit.org/show_bug.cgi?id=21596

Attachment 24352: Patch v1
https://bugs.webkit.org/attachment.cgi?id=24352&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Looking for feedback specifically on whether I should replace
isControlCharacter(UChar) with !isASCIIPrintable().

I think I should make trimToNextSeparator(const String&) inline as well.


More information about the webkit-reviews mailing list