[webkit-reviews] review granted: [Bug 21567] prepare-ChangeLog should know how to find functions in JavaScript files : [Attachment 24315] Proposed patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 21567: prepare-ChangeLog should know how to find functions in JavaScript
files
https://bugs.webkit.org/show_bug.cgi?id=21567

Attachment 24315: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24315&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
	 # Only look for function names in .c files.

Please fix this comment (I know it's been there forever).  Perhaps to "...in
certain source files."?

Also, please declare "sub get_function_line_ranges_for_javascript($$)" at the
top of the source file.

Otherwise looks great!	r=me with the above changes.