[webkit-reviews] review denied: [Bug 21581] http/tests/misc/frame-default-enc-same-domain.html should not depend on the presence of x-mac-cyrillic converter : [Attachment 24333] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 14 04:06:03 PDT 2008


Alexey Proskuryakov <ap at webkit.org> has denied 's request for review:
Bug 21581: http/tests/misc/frame-default-enc-same-domain.html should not depend
on the presence of x-mac-cyrillic converter
https://bugs.webkit.org/show_bug.cgi?id=21581

Attachment 24333: patch 
https://bugs.webkit.org/attachment.cgi?id=24333&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Sorry, I specifically chose MacCyrillic to make this test work reasonably on my
machine (where I have windows-1251 as a default encoding). I'd ask you to
change this to some encoding that is unlikely to be user default for any WebKit
developer.

On another note, I'm surprised that you can get away without supporting
MacCyrillic - this encoding is in wide use on the Web. Many Russian sites
re-encode their text to MacCyrillic on the fly if they see "Mac" in UA string
(a practice that makes no sense in this age, but anyway). Maybe you don't get
bug reports about this because you only have a Windows beta now?


More information about the webkit-reviews mailing list