[webkit-reviews] review granted: [Bug 21457] resolve-ChangeLogs should be able to operate on a git revision range : [Attachment 24300] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 13 11:04:47 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
https://bugs.webkit.org/show_bug.cgi?id=21457

Attachment 24300: Patch v2
https://bugs.webkit.org/attachment.cgi?id=24300&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
 265	 # On success, remove the backup refs directory
 266	 if (($? >> 8) == 0) {
 267	     rmtree(qw(.git/refs/original));
 268	 }

Should we use WEXITSTATUS (from the POSIX module) instead?

r=me!


More information about the webkit-reviews mailing list