[webkit-reviews] review denied: [Bug 19604] Re-enable 7 working layout tests : [Attachment 21755] re-enable 7 layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 12 16:47:18 PDT 2008

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 19604: Re-enable 7 working layout tests

Attachment 21755: re-enable 7 layout tests

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think you did enough research on why these tests were disabled.

For example, the two counters tests were disabled in
<http://trac.webkit.org/changeset/18642> with this comment: "disabled 3 tests
with results that are too font-dependent to be used as part of the test suite".
So we can't just re-enable those tests unless we resolve the issue about
getting appropriate fonts on everyone's computer.

And fast/frames/iframe-scroll-page-up-down.html fails when I run it on my
machine, so I don't agree that it's working.

The crash that fast/images/svg-background-crash-on-refresh.html was causing was
something that affected tests downstream. I'm not confident that bringing this
patch back won't bring back the reason we turned it off in the first place;
I'll need more evidence before doing that.

The create-list-1.html test does not give the expected result that's checked
in, so if we wanted to bring it back we'd have to fix the expected result.

Overall, this patch isn't usable as-is. Changing to review-.

More information about the webkit-reviews mailing list