[webkit-reviews] review granted: [Bug 21560] Layering violation: String should not be responsible for creating Lengths : [Attachment 24308] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 12 13:21:06 PDT 2008


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 21560: Layering violation: String should not be responsible for creating
Lengths
https://bugs.webkit.org/show_bug.cgi?id=21560

Attachment 24308: patch
https://bugs.webkit.org/attachment.cgi?id=24308&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The return values of these functions should be auto_ptr<Length>, not Length*.

r=me


More information about the webkit-reviews mailing list