[webkit-reviews] review requested: [Bug 16299] Add a config.h file to DRT : [Attachment 24295] Add a config.h file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 11 18:21:50 PDT 2008


Alp Toker <alp at nuanti.com> has asked  for review:
Bug 16299: Add a config.h file to DRT
https://bugs.webkit.org/show_bug.cgi?id=16299

Attachment 24295: Add a config.h file
https://bugs.webkit.org/attachment.cgi?id=24295&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
This adds config.h to DumpRenderTree.

I've updated the GTK and WIN DRT tools to use the new config.h.

Things that still need to be done (and that I don't have the tools to do):

  * Update the Mac port files
  * Add config.h to vsproj/xcodeproj files.

When adding support for your platform, make sure that the correct config.h is
being included in your DRT tool's sources!

When config.h has been added to all platforms, this can be removed from
DumpRenderTree.h:

// FIXME: Remove this when all platforms are using config.h
#ifndef Config_H
#include <wtf/Platform.h>
#endif


More information about the webkit-reviews mailing list