[webkit-reviews] review denied: [Bug 21536] Fix race condition in fast/repaint/bugzilla-6473.html : [Attachment 24282] Fixed test and new results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 20:47:40 PDT 2008

mitz at webkit.org has denied Pam Greene <pam at chromium.org>'s request for review:
Bug 21536: Fix race condition in fast/repaint/bugzilla-6473.html

Attachment 24282: Fixed test and new results

------- Additional Comments from mitz at webkit.org
The new result is correct, and the old result is wrong, probably due to the
"race condition". However, the patch is wrong. repaint.js is shared by many
repaint tests. Adding waitUntilDone() to runRepaintTest() will affect all those
tests -- making them wait for a notifyDone() that will never come and time out
10 seconds later. This style of repaint test -- the style that uses repaint.js
and runRepaintTest() should work without timeouts at when run in DumpRenderTree
(repaint.js has a timer-based code path for when you open the test in Safari).
This is an old test (originally a manual test!) and I think I did a poor job
when I automated it. Look at one of the newer repaint tests that use repaint.js
and try to fix this one to do the same thing.

More information about the webkit-reviews mailing list