[webkit-reviews] review denied: [Bug 21530] Don't test blocking 255.255.255.255 with no port : [Attachment 24274] Fixed test and Mac + Leopard results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 14:20:35 PDT 2008


Darin Adler <darin at apple.com> has denied Pam Greene <pam at chromium.org>'s
request for review:
Bug 21530: Don't test blocking 255.255.255.255 with no port
https://bugs.webkit.org/show_bug.cgi?id=21530

Attachment 24274: Fixed test and Mac + Leopard results
https://bugs.webkit.org/attachment.cgi?id=24274&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This doesn't seem right. We do need a test of the case with no specific port.
It's a separate code path, and in the past there have been bugs with it. And
this regression test will catch us if we break it again.

I assume that people at Google are running into this because of the Google
proxy configuration. Or is this a Chrome-specific issue?

What possible solutions are there besides removing the test?

review- for now


More information about the webkit-reviews mailing list