[webkit-reviews] review granted: [Bug 21529] Test fast/js/function-toString-parentheses.html is broken when removesExtraParentheses == false : [Attachment 24273] Fixes test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 14:11:10 PDT 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 21529: Test fast/js/function-toString-parentheses.html is broken when
removesExtraParentheses == false
https://bugs.webkit.org/show_bug.cgi?id=21529

Attachment 24273: Fixes test
https://bugs.webkit.org/attachment.cgi?id=24273&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The change is fine.

But this test is far less useful now than when it was written because neither
JavaScriptCore nor V8 really compile and serialize -- they both simply keep the
original function text around. So they pass this.

r=me


More information about the webkit-reviews mailing list