[webkit-reviews] review granted: [Bug 21526] The hashmap webPreferencesInstances in WebPreferences.cpp can potentially hold onto stale instances of WebPreferences : [Attachment 24270] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted 's request for review:
Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
potentially hold onto stale instances of WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=21526

Attachment 24270: Patch
https://bugs.webkit.org/attachment.cgi?id=24270&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
 3	   https://bugs.webkit.org/show_bug.cgi?id=21526

We normally put the title of the bug in the ChangeLog as well.

 619	 preferences = 0;
 620	 if (identifier) {
 621	     WebPreferences::removeReferenceForIdentifier(identifier);
 622	     SysFreeString(identifier);
 623	 }

It might be worth adding a comment here about why we release preferences first.


r=me