[webkit-reviews] review granted: [Bug 21506] Fix setUpPageStatus variable in two layout tests : [Attachment 24235] Fixes variable names to match

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 09:32:55 PDT 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 21506: Fix setUpPageStatus variable in two layout tests
https://bugs.webkit.org/show_bug.cgi?id=21506

Attachment 24235: Fixes variable names to match
https://bugs.webkit.org/attachment.cgi?id=24235&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The LayoutTests/dom tests were imported from an external source. Originally our
goal was to leave them as-is, and so we've made only minimal changes to them.

Back in 2005 we used to put comments around any WebKit modifications. For
example, search for WebKit in html/level1/core/selfhtml.js.

Later, we would still normally add comments. Seearch fro WebKit in
svg/level3/xpath/Text_Nodes.js.

So I think it would be slightly better to add a comment about the change, due
to the special status of LayoutTests/dom.

But this is good as-is I suppose. I'll just say r=me


More information about the webkit-reviews mailing list