[webkit-reviews] review requested: [Bug 21498] REGRESSION(r35966): Major canvas breakage : [Attachment 24239] Fix transformed patterns

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 21498: REGRESSION(r35966): Major canvas breakage
https://bugs.webkit.org/show_bug.cgi?id=21498

Attachment 24239: Fix transformed patterns
https://bugs.webkit.org/attachment.cgi?id=24239&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 LayoutTests/ChangeLog				    |	59 +++++++++++
 .../canvas/canvas-transform-identity-expected.png  |  Bin 3259 -> 10631 bytes
 .../canvas/canvas-transform-infinity-expected.png  |  Bin 3259 -> 10631 bytes
 .../canvas/canvas-transform-multiply-expected.png  |  Bin 3259 -> 10631 bytes
 .../fast/canvas/canvas-transform-nan-expected.png  |  Bin 3259 -> 10631 bytes
 .../canvas-transform-non-invertible-expected.png   |  Bin 3259 -> 10631 bytes
 .../canvas/canvas-transform-skewed-expected.png    |  Bin 3259 -> 10631 bytes
 .../canvas/canvas-before-css-expected.checksum     |	 2 +-
 .../mac/fast/canvas/canvas-before-css-expected.png |  Bin 9165 -> 17055 bytes
 .../mac/fast/canvas/canvas-bg-expected.png	    |  Bin 17964 -> 29420 bytes
 .../fast/canvas/canvas-composite-expected.checksum |	 2 +-
 .../mac/fast/canvas/canvas-composite-expected.png  |  Bin 20635 -> 30590 bytes
 .../canvas/canvas-draw-xbm-image-expected.checksum |	 2 +-
 .../fast/canvas/canvas-draw-xbm-image-expected.png |  Bin 3462 -> 10690 bytes
 .../canvas/canvas-resize-reset-expected.checksum   |	 2 +-
 .../fast/canvas/canvas-resize-reset-expected.png   |  Bin 7586 -> 15066 bytes
 ...nvas-size-change-after-layout-expected.checksum |	 2 +-
 .../canvas-size-change-after-layout-expected.png   |  Bin 7574 -> 15340 bytes
 .../fast/canvas/canvas-text-alignment-expected.png |  Bin 97978 -> 105596
bytes
 .../fast/canvas/canvas-text-baseline-expected.png  |  Bin 12181 -> 19326 bytes
 ...canvas-transforms-during-path-expected.checksum |	 2 +-
 .../canvas-transforms-during-path-expected.png     |  Bin 14377 -> 23272 bytes
 .../fast/canvas/canvasDrawingIntoSelf-expected.png |  Bin 8111 -> 16216 bytes
 .../mac/fast/canvas/drawImage-expected.png	    |  Bin 8111 -> 16216 bytes
 .../fillrect-gradient-zero-stops-expected.checksum |	 2 +-
 .../fillrect-gradient-zero-stops-expected.png	    |  Bin 20065 -> 29200 bytes
 .../canvas/fillrect_gradient-expected.checksum     |	 2 +-
 .../mac/fast/canvas/fillrect_gradient-expected.png |  Bin 51331 -> 88750 bytes
 ...ent-add-second-start-end-stop-expected.checksum |	 2 +-
 ...gradient-add-second-start-end-stop-expected.png |  Bin 3663 -> 14103 bytes
 .../canvas/gradient-empty-path-expected.checksum   |	 2 +-
 .../fast/canvas/gradient-empty-path-expected.png   |  Bin 9564 -> 19579 bytes
 .../image-object-in-canvas-expected.checksum	    |	 2 +-
 .../canvas/image-object-in-canvas-expected.png     |  Bin 48986 -> 58593 bytes
 .../canvas/patternfill-repeat-expected.checksum    |	 2 +-
 .../fast/canvas/patternfill-repeat-expected.png    |  Bin 38575 -> 50815 bytes
 .../fast/canvas/quadraticCurveTo-expected.checksum |	 2 +-
 .../mac/fast/canvas/quadraticCurveTo-expected.png  |  Bin 11850 -> 19600 bytes
 .../mac/fast/canvas/shadow-offset-1-expected.png   |  Bin 8875 -> 16958 bytes
 .../mac/fast/canvas/shadow-offset-2-expected.png   |  Bin 8927 -> 16986 bytes
 .../mac/fast/canvas/shadow-offset-3-expected.png   |  Bin 8875 -> 16958 bytes
 .../mac/fast/canvas/shadow-offset-4-expected.png   |  Bin 8892 -> 16971 bytes
 .../mac/fast/canvas/shadow-offset-5-expected.png   |  Bin 8892 -> 16971 bytes
 .../mac/fast/canvas/shadow-offset-6-expected.png   |  Bin 8930 -> 16989 bytes
 .../mac/fast/canvas/shadow-offset-7-expected.png   |  Bin 8939 -> 16996 bytes
 .../canvas/zero-size-fill-rect-expected.checksum   |	 2 +-
 .../fast/canvas/zero-size-fill-rect-expected.png   |  Bin 8044 -> 15632 bytes
 WebCore/ChangeLog				    |	27 +++++
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	 4 +
 WebCore/platform/graphics/GraphicsContext.cpp	    |	 4 -
 WebCore/platform/graphics/GraphicsContext.h	    |	 4 -
 .../graphics/cairo/GraphicsContextCairo.cpp	    |	17 ---
 WebCore/platform/graphics/cg/GraphicsContextCG.cpp |  105 +++++++++-----------
 WebCore/platform/graphics/qt/GraphicsContextQt.cpp |	16 ---
 WebCore/platform/graphics/wx/GraphicsContextWx.cpp |	16 ---
 55 files changed, 152 insertions(+), 128 deletions(-)