[webkit-reviews] review denied: [Bug 20947] Refactor RenderObject::setStyle code : [Attachment 24233] Final patch using CachedStyleChangeState struct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 9 12:53:49 PDT 2008

Dave Hyatt <hyatt at apple.com> has denied Simon Fraser <simon.fraser at apple.com>'s
request for review:
Bug 20947: Refactor RenderObject::setStyle code

Attachment 24233: Final patch using CachedStyleChangeState struct

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I hate the struct.  You've gone and taken something that had nothing to do with
any of the derived classes (and only had to do with RenderBox) and made it part
of the virtual function's argument list.  That makes no sense to me.  I think
statics in the RenderBox file are a much better way to handle this.

More information about the webkit-reviews mailing list