[webkit-reviews] review requested: [Bug 21465] Yet another querySelectorAll speedup : [Attachment 24186] The speedup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 8 02:38:20 PDT 2008

David Smith <catfish.man at gmail.com> has asked  for review:
Bug 21465: Yet another querySelectorAll speedup

Attachment 24186: The speedup

------- Additional Comments from David Smith <catfish.man at gmail.com>
I'm not real happy with the cleanliness of this code. Too many early returns,
and the tempSelector == querySelector to avoid code duplication with the
earlier id optimization is nasty.

That said, it works, passes tests, and speeds things up as expected.

More information about the webkit-reviews mailing list