[webkit-reviews] review requested: [Bug 20651] svgElement.className.baseValue does not work : [Attachment 24176] Fix painting of SVG <image> when the image must be scaled to retain aspect ratio

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20651: svgElement.className.baseValue does not work
https://bugs.webkit.org/show_bug.cgi?id=20651

Attachment 24176: Fix painting of SVG <image> when the image must be scaled to
retain aspect ratio
https://bugs.webkit.org/attachment.cgi?id=24176&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>

Reviewed by Niko

Also added new layout test for this bug, and corrected old expected output


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29275
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 LayoutTests/ChangeLog				    |	25 ++++++++++++++++++++
 .../animate-elem-30-t-expected.checksum	    |	 2 +-
 .../svg/W3C-SVG-1.1/animate-elem-30-t-expected.png |  Bin 20612 -> 20691 bytes
 .../animate-elem-36-t-expected.checksum	    |	 2 +-
 .../svg/W3C-SVG-1.1/animate-elem-36-t-expected.png |  Bin 32491 -> 32406 bytes
 .../animate-elem-39-t-expected.checksum	    |	 2 +-
 .../svg/W3C-SVG-1.1/animate-elem-39-t-expected.png |  Bin 37743 -> 38282 bytes
 .../svg/carto.net/selectionlist-expected.checksum  |	 2 +-
 .../mac/svg/carto.net/selectionlist-expected.png   |  Bin 208607 -> 208824
bytes
 ...age-with-aspect-ratio-stretch-expected.checksum |	 1 +
 .../image-with-aspect-ratio-stretch-expected.png   |  Bin 0 -> 3250 bytes
 .../image-with-aspect-ratio-stretch-expected.txt   |	11 ++++++++
 .../custom/pointer-events-image-expected.checksum  |	 2 +-
 .../svg/custom/pointer-events-image-expected.png   |  Bin 71136 -> 68766 bytes
 .../custom/text-image-opacity-expected.checksum    |	 2 +-
 .../mac/svg/custom/text-image-opacity-expected.png |  Bin 17588 -> 17393 bytes
 .../svg/custom/image-with-aspect-ratio-stretch.svg |	17 +++++++++++++
 WebCore/ChangeLog				    |	11 ++++++++
 WebCore/rendering/RenderSVGImage.cpp		    |	16 ++++++------
 19 files changed, 79 insertions(+), 14 deletions(-)