[webkit-reviews] review requested: [Bug 20651] svgElement.className.baseValue does not work : [Attachment 24172] 2008-01-07 Jon Honeycutt <jhoneycutt at apple.com>

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20651: svgElement.className.baseValue does not work
https://bugs.webkit.org/show_bug.cgi?id=20651

Attachment 24172: 2008-01-07  Jon Honeycutt  <jhoneycutt at apple.com>
https://bugs.webkit.org/attachment.cgi?id=24172&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>

	Reviewed by Hyatt.

	<rdar://problem/5673489> Safari does not render windowless plugins in
an
	iframe when opacity < 1.0

	Plugins in transparency layers handle their own world transforms, so
	only apply the horizontal/vertical transform if we are not in a
	transparency layer.

	* platform/graphics/GraphicsContext.h: Add a Windows-platform-only
	inTransparencyLayer() function
	* platform/win/GraphicsContextWin.cpp:
	(WebCore::GraphicsContext::getWindowsContext): Use
inTransparencyLayer()
	(WebCore::GraphicsContext::inTransparencyLayer):
	(WebCore::GraphicsContext::releaseWindowsContext): Use
	inTransparencyLayer()
	* plugins/win/PluginViewWin.cpp:
	(WebCore::PluginViewWin::paint): When retrieving the HDC, use the rect
	relative to the window. Pass m_isTransparent to
	get/releaseWindowsContext(). Only set the world transform if we are not
	in a transparency layer.




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29270
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 WebCore/ChangeLog			     |	 24 ++++++++++++++++++++++++
 WebCore/platform/graphics/GraphicsContext.h |	  1 +
 WebCore/platform/win/GraphicsContextWin.cpp |	  6 ++++--
 WebCore/plugins/win/PluginViewWin.cpp	     |	 27 +++++++++++++--------------
 4 files changed, 42 insertions(+), 16 deletions(-)